feat: added pid filtering searchbox and selection counter in snapshot download popup #5627
Conversation
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
sfiorani
changed the title
| @@ -0,0 +1,26 @@ | |||
| package org.eclipse.kura.web.client.ui.settings; | |||
There was a problem hiding this comment.
I think we can already put 2025 at this point.
| @@ -316,7 +316,10 @@ downloadSnapshotXmlButton=Download as XML | |||
| downloadSnapshotJsonButton=Download as JSON | |||
| downloadSnapshotError=Please select at least one pid from the list | |||
| selectAllAnchorText=Select All Pids | |||
| selectAllVisibleAnchorText=Select All Visible Pids | |||
There was a problem hiding this comment.
I believe we need to get consistent on how we display PIDs. In some places is PIDs, in others is Pids
I believe we need to converge to PIDs
Signed-off-by: SimoneFiorani <[email protected]>
|
A potential corner case that I've found is related to when the session is ended. You can still select the snapshot and perform your actions to try to download. But after clicking on the download as button, you get no output or feedback. |
Yes I can reproduce this wrong behaviour. However, I have already a PR which follows this one and migrates all the snapshot download requests from GET to POST ones. This new mechanism will generate a new token for each download, preventing this situation and triggering the "Session expiration" popup. This will align the snapshot download failure to what happens in the rest of the framework |
Signed-off-by: SimoneFiorani <[email protected]>
...e.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/settings/SnapshotDownloadModal.java
Outdated
Show resolved
Hide resolved
…client/ui/settings/SnapshotDownloadModal.java Co-authored-by: Matteo Maiero <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
This PR updates what was contributed in #5617 with the following updates:
Related Issue: This PR fixes/closes {issue number}
Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped
Screenshots: If applicable, add screenshots to help explain your solution
Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review
Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]